BMWheels

Hi i just recently made a tekkit server and my friends can not connect to it. I read up on the internet and people say the you need to give them you public ip. I did that and they still could bot connet to it. I can get on it with out any problems. Is there anything that i am missing? Please get back to me. Thx BMWheels