Launcher does not handle redirects

[DrJ]

Launcher Version: 1.0.1.3

Operating System: Windows 7

Java Version: java version "1.7.0_01"

Antivirus Program:

Description of Problem:

When starting the launcher it tried to update it self using the available network connection. Unfortunately the hot spot I had connected to uses a http redirect to point any http requests to itself so you can read the terms of use and hit the accept button. The launcher rewrote the technic-launcher.jar with the html from the redirected site. Then tried to use java to run it, which of course failed. Unfortunately there was no error message just a quiet failure and it took me a couple of tries before I figured out what was going on.

Is there any way of having the exe test the returned file before installing it, and perhaps issuing a redirect warning?

The simple fix was to use my browser to accept the terms of use and re-launch the exe launcher on my desktop which then downloaded the correct jar file and ran it with no problems.

Error Messages:

Error Log:

[tepidpond]

Ooh, a fun bug. I'll see if I can get that fixed.

[Jorcer]

Launcher Version: 1.0.1.3

Operating System: Windows 7

Java Version: java version "1.7.0_01"

Antivirus Program:

Description of Problem:

When starting the launcher it tried to update it self using the available network connection. Unfortunately the hot spot I had connected to uses a http redirect to point any http requests to itself so you can read the terms of use and hit the accept button. The launcher rewrote the technic-launcher.jar with the html from the redirected site. Then tried to use java to run it, which of course failed. Unfortunately there was no error message just a quiet failure and it took me a couple of tries before I figured out what was going on.

Is there any way of having the exe test the returned file before installing it, and perhaps issuing a redirect warning?

The simple fix was to use my browser to accept the terms of use and re-launch the exe launcher on my desktop which then downloaded the correct jar file and ran it with no problems.

Error Messages:

Error Log:

Just to clarify, did you fix it? If you did (from what I see you seem to) consider making it a little more obvious so others can read and fix similar issues.

[DrJ]

Just to clarify, did you fix it? If you did (from what I see you seem to) consider making it a little more obvious so others can read and fix similar issues.

Running the executable after signing into the WiFi point will re-download the jar file but that only works if you can sign in. If you only have tried to start the launcher only once you could also remove the jar file and rename the jar.bak file over it. But if you can't do either of these you can't play until you get internet access. The launcher should catch this, not install the file and possibly inform the user that the internet is being redirected.

[tepidpond]

I've written and submitted a patch for this issue, DrJ. It checks for the 'magic bytes' that only zipped files (which jarfiles are) has, and shows a warning if the downloaded file doesn't start with them (which would happen if it'd been redirected to a wifi point signin page). It may take several days or longer for this fix to get validated and work its way onto the website, unfortunately.

[Jorcer]

Nice work, glad you submitted a second fix in as many weeks :)

[DrJ]

I've written and submitted a patch for this issue, DrJ. It checks for the 'magic bytes' that only zipped files (which jarfiles are) has, and shows a warning if the downloaded file doesn't start with them (which would happen if it'd been redirected to a wifi point signin page). It may take several days or longer for this fix to get validated and work its way onto the website, unfortunately.

Thanks for the quick work, Not really a big issue but defiantly a annoying one.