Public ip not working

[Ambient_]

Hi im working on setting up a tekkit legends server for me and my friends and so far i have got it working on lan, i have port fowarded the server and everything, alowed the port through my fire wall but my frineds cant connect through my public ip, am i doing anything wrong?

 

(if it helps i installed thermal expansion and a new version of cofh core)

[JaariAtmc]

Correct IP stated in server.properties?

[Ambient_]

In the how to video i watched it said not to add an ip to the server.properties, Do i add the ipv4 or my public ip?

[JaariAtmc]

4 hours ago, Ambient_ said:

In the how to video i watched it said not to add an ip to the server.properties, Do i add the ipv4 or my public ip?

If I remember correctly, the IP stated when you were portforwarding.

[Hali]

What IP did you portforward?, Internal or External?  (External is from IP chicken, and Internal is from CMD).