Launcher has capability to delete Appdata and all contents

[MercuryFyre]

When adding a custom mod pack to the launcher, I muddled up the install directory (my first time adding a custom pack). Obviously it didn't work after having tried downloading and running it, so I told the launcher to remove the pack from the list so I could try again. Instead of deleting the files the launcher installed, it deleted the entire contents of my AppData and the items around it, including my pictures, music, and another 21.9 GB of files.

I have to admit, this is kinda sloppy coding, and I'd like for people to be aware of this when setting their install directory.

[Olloth]

When did you install the launcher? It should have popped up a confirmation window telling you which folder would be deleted.

[FlamingSock]

Well, if this person installed the modpack to AppData, instead of making a folder inside AppData, then the launcher would delete everything in AppData, correct?

[Olloth]

Well, if this person installed the modpack to AppData, instead of making a folder inside AppData, then the launcher would delete everything in AppData, correct?

It would, but the end of march I prevented people from selecting folders that have anything inside them anymore. So he had to have selected AppData before march 31st, and then ALSO ignored the message that popped up that said "This will delete everything in *folder path* Are you sure?"

If he didn't get that message, or it let him select a folder that had stuff in it after march 31st, then he's either on an old launcher build, or I actually have a bug I didn't know about.

Otherwise, it's just personal error on his part. I am still very sorry that this bug ever existed but I did everything in my power to make it fixed. Unfortunately there is no good way to go back and check on peoples folder structure and "know" if it's in a dumb place or not. That is why I added the message "This will delete everything in *folder path* Are you sure?"

[MercuryFyre]

I installed the launcher yesterday (made the post yesterday as well) since I primarily use FTB, but FTB is stuck on 1.4.7 for now. No, I was not prevented from installing the mod in the wrong place, nor was I given any sort of warning message (Maybe because it's a custom pack?). I just heard my hard drive chugging away, and realized what had happened when my music folder was gone

Luckily Windows has a restore backups function, so everything is fixed, but yeah... No warnings or anything.

[Olloth]

I installed the launcher yesterday (made the post yesterday as well) since I primarily use FTB, but FTB is stuck on 1.4.7 for now. No, I was not prevented from installing the mod in the wrong place, nor was I given any sort of warning message (Maybe because it's a custom pack?). I just heard my hard drive chugging away, and realized what had happened when my music folder was gone

Luckily Windows has a restore backups function, so everything is fixed, but yeah... No warnings or anything.

What exactly did you do?

You installed the launcher yesterday (Should be build #224)

You installed a custom pack (If you can link me the pack that might help, just to be sure I'm testing the same way)

You selected the AppData folder as the install location.

The pack installed, I assume.

Then you, did what? Did you press delete? Or reset pack? Or use the options to try and move the folder? Or something else?

If you can remember all the exact steps and I check if it can be reproduced and fix it.

I'm sorry this happened, as long as you're willing to keep helping me get to the bottom of this I'll get it fixed. I am quite embarrassed and mad at myself that this happened, trust me.

[MercuryFyre]

Build is indeed 224.

Custom mod pack: http://www.technicpack.net/modpack/details/goonies

I'm not 100% sure what folders I set it to install in, but I know I did it wrong. It asked for an install directory, which I set to C:\Users\MercuryFyre\AppData\Roaming\.technic\goon, but then it asked for something outside of .technic, which isn't something I've ever seen an installation ask for, so it had me confused. It wasn't accepting any folders I gave it (The "select" button didn't do anything) until I evidently told it the wrong folder.

Once I got it to accept a folder, being pretty disoriented by it asking for a folder outside of a folder and it not working when I did, I got it to install. It didn't get as far as the Mojang screen, instead just being the dirt texture, so I closed it and hit the red minus button in the bottom right of the modpack's icon in the launcher. At that point the launcher didn't want to close and my hard drive was chugging away so I just kinda left it alone for a while.

Don't feel too bad, I got 99% of my files back because Windows is awesome, but thanks for looking into it :)

[Olloth]

Alright. The reason it asks for an install location outside of .technic is there is an option for custom modpacks to require the installation to be outside .technic.

This is because some mod authors like checking your computer for .technic and then crashing or breaking things. I can try and make it more clear what sort of folder structure you need to select though. It's a little confusing.

It did indeed let me select AppData which is a problem I will fix right now. However, it also did ask me when I pressed the red minus, Yes or No, and in the Yes or No message it said "This will delete everything in C:/redactedfolders/AppData/ so I believe you probably just clicked through without reading it. I'm absolutely positive that window pops up.

In any case, I will be fixing the AppData folder issue right now. Thanks for the report. Sorry about the mess and confusion/frustration.

[MercuryFyre]

All good, I may have clicked through it, I can't really remember. Thanks for the help/acknowledgment of the bug, I'll try installing again later :P

[Olloth]

https://github.com/TechnicPack/TechnicLauncher/commit/814f5d357c08200c332ac8cc0cd031e6cd359c8d

Fixed this bug (again). I also have fixed it when you select the launcher install directory, the launcher change directory, and the modpack change directory. I just messed up bad and forgot the modpack install directory.

Build will be promoted to stable and it will automatically roll out, no work needed on your part for updating. Build #236